learn with eyes open, roll with eyes closed
When learning in calm water or a pool I kept my eyes open to ensure proper paddle placement, to look at the blade to see if it was diving etc. Once that was embedded in my muscle memory I rolled with my eyes closed. On the river, I keep my eyes closed most of the time. Dirt and grains or sand and crap can get in your eye and that really hurts. I have opened my eyes when I haven't just hit the roll right away (stuck in hole, swimming, getting recirced etc). For the basic 1st roll on the river, I would generally keep my eyes closed, but that happens by instinct.